[NET-553] Improve host upgrade message handling #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielseibel1
requested review from
Aceix,
theguy951357,
pwilson77,
afeiszli,
abhishek9686,
mattkasun and
uGiFarukh
mattkasun
approved these changes
Sep 14, 2023
abhishek9686
approved these changes
Sep 15, 2023
Aceix
approved these changes
Sep 19, 2023
|
resolve conflicts |
|
@abhishek9686 Needs gravitl/netmaker#2582 to be merged to link to that new netmaker version in go.mod |
you can now rebase and update go mod |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Now the message handling for the UPGRADE message handles non-semver versions better (doesn't panic)
Also the autoupdate on connection was improved to have the same resilience
Needs gravitl/netmaker#2582 to be merged to link to that new netmaker version in go.mod
Provide testing steps
Described in ticket